[PATCH] Adding --send-{eth|ip} to Zenmap

[Kris Katterjohn <katterjohn () gmail com>]

Hey everyone!

I sometimes find myself wanting to use --send-ip for pinging on a LAN 
(instead of the ARP Ping), so I've attached a patch to add this option 
(and --send-eth) to Zenmap's Profile Editor (but not the Wizard this time).

I've also attached a screenshot showing how I've added it, as this is 
another option I'd like an opinion on.  Is it in a good place?  Should 
the options be named differently?

I think it fits in decent enough with the other options in this tab (TTL 
and fragmentation), and the option names are short and simple.

Thanks,
Kris Katterjohn

Index: zenmap/share/zenmap/misc/profile_editor.xml
===================================================================
--- zenmap/share/zenmap/misc/profile_editor.xml (revision 6800)
+++ zenmap/share/zenmap/misc/profile_editor.xml (working copy)
@@ -72,6 +72,11 @@
     <option_check label="Extra options defined by user" option="Extra" arg_type="str"/>
     <option_check label="Set IPv4 time to live (ttl)" option="Set IPv4 ttl" arg_type="str"/>
     <option_check label="Fragment IP packets" option="Fragment IP Packets"/>
+    <option_list label="Packet Sending Preference">
+      <option name="None"/>
+      <option name="Raw IP Socket"/>
+      <option name="Ethernet Frames"/>
+    </option_list>    
     <option_check label="Verbosity level" option="Verbose" arg_type="level"/>
     <option_check label="Debugging level" option="Debug" arg_type="level"/>
     <option_check label="Watch packets" option="Watch packets"/>
Index: zenmap/share/zenmap/misc/options.xml
===================================================================
--- zenmap/share/zenmap/misc/options.xml        (revision 6800)
+++ zenmap/share/zenmap/misc/options.xml        (working copy)
@@ -407,4 +407,16 @@
           hint="Watch packet while they go through the network"
           arguments=""
           need_root="0"/>
+
+  <option name="Raw IP Socket"
+          option="--send-ip"
+          hint="Try to send packets via raw IP sockets"
+          arguments=""
+          need_root="0"/>
+          
+  <option name="Ethernet Frames"
+          option="--send-eth"
+          hint="Try to send packets via ethernet frames"
+          arguments=""
+          need_root="0"/>
 </nmap_options>
Index: zenmap/zenmapCore/UserConf.py
===================================================================
--- zenmap/zenmapCore/UserConf.py       (revision 6800)
+++ zenmap/zenmapCore/UserConf.py       (working copy)
@@ -173,6 +173,11 @@
     <option_check label="Extra options defined by user" option="Extra" arg_type="str"/>
     <option_check label="Set IPv4 time to live (ttl)" option="Set IPv4 ttl" arg_type="str"/>
     <option_check label="Fragment IP packets" option="Fragment IP Packets"/>
+    <option_list label="Packet Sending Preference">
+      <option name="None"/>
+      <option name="Raw IP Socket"/>
+      <option name="Ethernet Frames"/>
+    </option_list>    
     <option_check label="Verbosity level" option="Verbose" arg_type="level"/>
     <option_check label="Debugging level" option="Debug" arg_type="level"/>
     <option_check label="Watch packets" option="Watch packets"/>
@@ -601,6 +606,18 @@
           hint="Watch packet while they go through the network"
           arguments=""
           need_root="0"/>
+          
+  <option name="Raw IP Socket"
+          option="--send-ip"
+          hint="Try to send packets via raw IP sockets"
+          arguments=""
+          need_root="0"/>
+          
+  <option name="Ethernet Frames"
+          option="--send-eth"
+          hint="Try to send packets via ethernet frames"
+          arguments=""
+          need_root="0"/>
 </nmap_options>'''
 
 wizard_content = '''<?xml version="1.0"?>

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org