Re: [PATCH] Improved WinPcap x64 Support

[Rob Nicholls <robert () robnicholls co uk>]

On Wed, 21 Apr 2010 18:50:33 -0700, Fyodor <fyodor () insecure org> wrote:
> Thanks Rob.  Given the lack of bug reports, this change seems to be
> working well!

Good to hear!

> But I'm browsing through the NSI to help a user and
> have a question about this section added last October:
>
> InstDir64bit:
>    ExecWait '"$INSTDIR\winpcap-nmap-4.11.exe" $1 /S
>    /D=$\""$PROGRAMFILES64\WinPcap\"$\"'
>       Goto InstDirDone
>    InstDir32bit:
>       ExecWait '"$INSTDIR\winpcap-nmap-4.11.exe" $1 /S
>       /D=$\""$PROGRAMFILES\WinPcap\"$\"'
>
> I'm not sure if this is needed, as the winpcap-nmap.nsi seems to do
> some 64 bit detection too.

You're right, I don't think it is needed anymore. It was in the past
because we needed to pass an installation directory that's appropriate for
the OS as our WinPcap installer was originally written to prompt for one
(and we obviously can't do that with a silent install). But in the latest
update, everything is effectively hardcoded so files end up in the same
place as the official installer (almost all of the files end up somewhere
in the WINDOWS directory anyway) so I don't think it matters what we pass
it anymore as I believe it's ignored completely. I'll try cleaning up that
redundant code in Nmap.nsi and check that it doesn't break anything before
submitting a patch.

Rob

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/